FOR THE PEOPLE WHO APPROVE CHANGES
“That line can go.” Are you sure?
In a review, a deleted line looks harmless. Whether it protected a customer from being charged twice is written down nowhere. With FACET it is written right next to it — and the review asks before it gets expensive.
// @facet: checkout/payment/charge-onceexport async function charge(order: Order) { if (await alreadyCharged(order.id)) return; await gateway.charge(order.id, order.total);}
Illustrative example · one line in a diff that looks harmless
WHAT FACET FLAGS IN REVIEW
The code changed. Its description didn’t. On purpose?
At the end of every change, FACET names each file whose code moved while the description of its feature stayed the same. Next to it sits the case the deleted line was protecting. The review gets a concrete question instead of a gut feeling.
contract: scenarios: - id: second-click-charges-once given: an order of 100 € was charged when: the customer submits payment again then: no second charge is made
decision: "block"FACET: source implementing these features changed,but their records did not:- checkout/payment/charge-once — changed: src/checkout/payment.ts
Illustrative example · shaped like FACET’s stop hook
WHAT THE LINE PROTECTED
The diff loses one line. The customer gets charged twice.
One order, two clicks. With the line, the customer pays once. Without it, they pay twice: same interface, different business rule.
the agreed rule
100 €
One order. One payment. Even when the customer clicks twice.
− duplicate-payment guard
200 €
Second click. Second charge. Same interface, different business rule.
“Can this go?” gets context.
WHAT FACET DOES NOT DO HERE
A notice is not a verdict.
FACET prompts a review. Reviewers and tests still establish whether there is a bug.